Clean up and improve layers api #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s so they no longer error in annoying ways
ljeub-pometry
force-pushed
the
feature/ImprovedLayersAPI
branch
from
ac09baa
to
d74e006
Compare
miratepuffin
approved these changes
Jan 18, 2024
fabianmurariu
pushed a commit
that referenced
this pull request
May 21, 2024
* add has_layer and valid_layers and change GQL apis to use valid_layers so they no longer error in annoying ways * fix has_layer for layered graph * clean up Layer conversion implementations * add test * clean up warnings * fmt * make sure materialize doesn't drop layers --------- Co-authored-by: Ben Steer <b.a.steer@qmul.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
valid_layersandhas_layermethods for easy checking of valid layers and ignoring invalid inputvalid_layers, restoring the old behaviour where non-existing layers are ignored instead of causing errorsWhy are the changes needed?
quality of life
Does this PR introduce any user-facing change? If yes is this documented?
yes, new methods have docstrings
How was this patch tested?
added more tests for layering
Issues
Are there any further changes required?
Current behaviour for edges can be weird as they have two ways to specify layer (see #1458)