Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with path while saving and loading graphs #1627

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

shivam-880
Copy link
Collaborator

What changes were proposed in this pull request?

Saving graph to a relative path was not getting loaded from the same path

Why are the changes needed?

Same as above

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

No

Issues

If this resolves any issues, please link to them here, the format is a KEYWORD followed by @_
KEYWORDS available are close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved.
Please delete this text before creating your PR

Are there any further changes required?

No

@shivam-880
Copy link
Collaborator Author

shivam-880 commented May 30, 2024

Fixes #1628

Copy link
Collaborator

@miratepuffin miratepuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small test to this for absolute and relative paths?

@miratepuffin miratepuffin merged commit 981101d into master Jun 3, 2024
13 checks passed
@miratepuffin miratepuffin deleted the fix/save-load branch June 3, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants