Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature flags): info banner when a flag can't be scheduled #25185

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Sep 24, 2024

Problem

Raised by @leonposthog

Hey team - I have a question regarding role based access for Feature Flags, it looks like a user who only has "Feature Flags View" permissions, can still use the Scheduling feature of feature flags, is that expected?

Changes

Permissioning is handled at the API level, so any update attempt by a user without the edit permissions would already fail when trying to execute a scheduled flag change.

Now adding a banner to inform non-permissioned users that they need to request edit permissions before scheduling.

image

How did you test this code?

👀

@jurajmajerik jurajmajerik requested a review from a team September 24, 2024 20:00
Copy link
Contributor

Size Change: 0 B

Total Size: 2.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.06 MB

compressed-size-action

Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@jurajmajerik jurajmajerik merged commit 6c5a104 into master Sep 25, 2024
96 checks passed
@jurajmajerik jurajmajerik deleted the feature-flag-schedule-permission-banner branch September 25, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants