Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cohorts): correct crontab schedules #25199

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

skoob13
Copy link
Contributor

@skoob13 skoob13 commented Sep 25, 2024

Problem

crontab only supports kwargs while I was passing it using a single string. Correct the schedules to use get_crontab function.

Changes

Use get_crontab.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Manual testing.

@skoob13 skoob13 requested a review from a team September 25, 2024 12:18
@skoob13 skoob13 enabled auto-merge (squash) September 25, 2024 12:32
@skoob13 skoob13 merged commit 50fb40f into master Sep 25, 2024
86 checks passed
@skoob13 skoob13 deleted the fix/crontab-for-cohorts branch September 25, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants