Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(experiment): relocate funnel statistical methods #25202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jurajmajerik
Copy link
Contributor

Problem

The statistical methods in funnel_experiment_results need to be accessible to both the old and new implementations.

Changes

There are no functional changes, only some restructuring:

  • Moved these methods to a new location and imported them into:
    • trend_experiment_results (old implementation)
    • experiment_funnel_query_runner (new implementation)
  • Moved the experiment query runner and related files to a separate folder
  • Split the old Trend and Funnel test methods into separate files

How did you test this code?

Existing tests pass

@jurajmajerik jurajmajerik requested a review from a team September 25, 2024 13:47
Copy link
Contributor

Size Change: 0 B

Total Size: 2.06 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 2.06 MB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants