Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure show-invisibles compat with autoloader #874

Merged
merged 1 commit into from
Feb 1, 2016

Conversation

mAAdhaTTah
Copy link
Member

When using the autoloader, the language isn't loaded
at the time the show-invisibles plugin attaches its
extra tokens. This defers attaching the extra tokens
to just before highlighting, so we ensure we're able
to attach to the language grammar.

When using the autoloader, the language isn't loaded
at the time the show-invisibles plugin attaches its
extra tokens. This defers attaching the extra tokens
to just before highlighting, so we ensure we're able
to attach to the language grammar.
mAAdhaTTah added a commit to intraxia/wp-gistpen that referenced this pull request Jan 30, 2016
The show invisibles plugin needs to be handled
differently. A PR is open upstream to resolve this
issue: PrismJS/prism#874
mAAdhaTTah added a commit to intraxia/wp-gistpen that referenced this pull request Jan 30, 2016
The show invisibles plugin needs to be handled
differently. A PR is open upstream to resolve this
issue: PrismJS/prism#874

Fixes #49
@zeitgeist87
Copy link
Collaborator

Your solution is correct. In the future we should add some kind of language-loaded hook.

zeitgeist87 added a commit that referenced this pull request Feb 1, 2016
Ensure show-invisibles compat with autoloader
@zeitgeist87 zeitgeist87 merged commit 5b9bf72 into PrismJS:gh-pages Feb 1, 2016
@zeitgeist87
Copy link
Collaborator

Thanks!

@mAAdhaTTah mAAdhaTTah deleted the autoloader-compat branch February 13, 2016 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants