Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for asynchronous loading of prism.js #959

Merged
merged 2 commits into from
Jun 3, 2016

Conversation

rupl
Copy link
Contributor

@rupl rupl commented May 26, 2016

I found #75 while trying to implement Prism on my personal site and figured the issue could use a PR. It uses the fix within the comments of the issue.

@LeaVerou
Copy link
Member

Oh wow, I thought we fixed that ages ago. Thanks for spotting that!
I would suggest requestAnimationFrame instead of setTimeout.
Otherwise, LGTM, but I want someone else on the team to weigh in too before merging.

@rupl
Copy link
Contributor Author

rupl commented May 29, 2016

No problem, branch is updated with rAF.

@zeitgeist87
Copy link
Collaborator

I've reproduced the bug and confirmed that the solution works. Thanks!

@zeitgeist87 zeitgeist87 merged commit 0c4d8d7 into PrismJS:gh-pages Jun 3, 2016
@rupl
Copy link
Contributor Author

rupl commented Jun 3, 2016

woohoo! 🎉

@WickyNilliams
Copy link

Thanks for this! My little hacky solution from years ago finally made it in :)

@brendanfalkowski
Copy link

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants