Proceds blockly variables #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlopezalvas
commented
Aug 8, 2024
Comment on lines
-146
to
+151
| "type": "field_variable", | ||
| "type": "field_label", |
There was a problem hiding this comment.
Esto es lo que hace que los callers de los parámetros en los procedimientos no tengan el menú molesto. También hace que funcione el cambio de nombres de los parámetros.
dlopezalvas
commented
Aug 8, 2024
| @@ -214,379 +218,6 @@ export const createCommonBlocklyBlocks = (t: (key: string) => string, color: str | |||
| } | |||
| } | |||
|
|
|||
| Blockly.Blocks['procedures_defnoreturn'] = { | |||
There was a problem hiding this comment.
Entiendo que en blockly-proceds estamos redefiniendo todo este bloque, por lo que lo que sea que se haga acá se está pisando. No se de donde salio, quizás habría que comparar con más ojo las diferencias que tienen con blockly-proceds o si soluciona alguno de los problemas que tenemos. Por ahora sacarlo no cambio nada.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #248
blockly-proceds: