-
-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ValueError on comment after ignore in .flake8 config #1756
Comments
I'm reasonably confident that having a comment after the ignore used to work. |
duplicate #1753, and it's in the changelog Apparently flake8 has always been treating these not as comments, but as additional error codes to ignore. (They just happened not to be valid error codes). You might think that a sensible fix would have been to recognise comments, but they've instead gone with "that's not a valid error code, too bad". Raising a feature request to ask for that would be logical, I assume that reporting it as a bug will just be dismissed. |
So apparently a duplicate of #1753, #1750 and #1745. I did read the release notes, and actually also looked at the change but it seemed to be related to "invalid comments", in the style of For reference, the issue #1689 and PR #1713 (both linked in the release notes) do not make it clear that any type of inline comments are now considered an error. |
Flake8 version 6 now breaks on inline comments in the config. This is a workaround for that. See PyCQA/flake8#1756
Flake8 version 6 now breaks on inline comments in the config. This is a workaround for that. See PyCQA/flake8#1756
how did you install flake8?
unmodified output of
flake8 --bug-report
describe the problem
what I expected to happen
I have a very simple .flake8 config file
I'd expected running flake8 after the upgrade would work, instead I get a traceback:
In order to get the correct result for
flake8 --bug-report
I had to change the config file to:commands ran
The text was updated successfully, but these errors were encountered: