Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate RustExtension.py_limited_api #410

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

davidhewitt
Copy link
Member

I'd like to simplify the RustExtension options a little further and remove the py_limited_api setting, as I think users should always use "auto" and use [bdist_wheel] configuration to set up an abi3 build.

If the PyO3 module should be built in abi3 mode for local (i.e. non-wheel) builds too, then that configuration is probably better placed in the Cargo.toml than in the setuptools-rust layer.

cc @alex as you implemented this setting originally, but I think cryptography has now also switched to auto mode.

@alex
Copy link
Contributor

alex commented Feb 1, 2024

Yes, we now use auto + features = ["abi3"] in Cargo.toml + --config-settings=--build-option=--py-limited-api=${{ matrix.PYTHON.ABI_VERSION }} when building release wheels.

Which I think means this is fine for us.

@davidhewitt
Copy link
Member Author

Great! I should probably also add the --config-settings option to the docs too 👍

@davidhewitt davidhewitt merged commit 5dd65e2 into PyO3:main Feb 2, 2024
40 checks passed
@davidhewitt davidhewitt deleted the abi3-cleanup branch February 2, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants