Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI on Master branch #145

Merged
merged 5 commits into from
Aug 29, 2022
Merged

Fix CI on Master branch #145

merged 5 commits into from
Aug 29, 2022

Conversation

jenshnielsen
Copy link
Collaborator

@jenshnielsen jenshnielsen commented Aug 29, 2022

  • Fixes to support latest mypy
  • Change intersphinx links to avoid warnings
  • Bump min qcodes version to prevent pip looking for an older qcodes version that supports ipywidgets 8 (which in turn depend on netcdf4 which ships sdist but not wheels for 3.7 which causes a build failure)
  • Remove nitpick warnings that are unused and may trigger warnings
  • Stop using qcodes requirements file. This causes install issues when qcodes has already bumped something on master that the release does not yet support (such as ipywidgets)

Note for now I have only added mypy to the local requirements (constraints) file. We should perhaps add more important dependencies that we know often breaks on upgrade (sphinx ..) and enable dependabot here too

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2022

Codecov Report

Merging #145 (ea1c377) into master (e4b57ba) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   19.02%   19.02%           
=======================================
  Files         124      124           
  Lines       14935    14935           
=======================================
  Hits         2842     2842           
  Misses      12093    12093           
Impacted Files Coverage Δ
...trib_drivers/drivers/NationalInstruments/Switch.py 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jenshnielsen jenshnielsen merged commit 5fca1e2 into QCoDeS:master Aug 29, 2022
@jenshnielsen jenshnielsen deleted the fix_ci branch August 29, 2022 11:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants