Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QDevil QDAC2: Leakage sweep #158

Merged
merged 5 commits into from
Oct 17, 2022
Merged

QDevil QDAC2: Leakage sweep #158

merged 5 commits into from
Oct 17, 2022

Conversation

jpsecher
Copy link
Contributor

  • set_virtual_voltage affects whole arrangement

- set_virtual_voltage affects whole arrangement
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022

Codecov Report

Merging #158 (d1382d4) into master (8bac704) will increase coverage by 0.58%.
The diff coverage is 97.36%.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   18.80%   19.38%   +0.58%     
==========================================
  Files         123      124       +1     
  Lines       15581    15696     +115     
==========================================
+ Hits         2930     3043     +113     
- Misses      12651    12653       +2     
Impacted Files Coverage Δ
qcodes_contrib_drivers/drivers/QDevil/QDAC2.py 96.44% <95.28%> (-0.04%) ⬇️
...rib_drivers/tests/QDevil/test_sim_qdac2_leakage.py 100.00% <100.00%> (ø)
...ivers/tests/QDevil/test_sim_qdac2_virtual_gates.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jpsecher
Copy link
Contributor Author

After talking with Fabrizio, Torbjørn, Joost, etc at NBI, we decided to call output channels for "contacts" to avoid confusion of what an "arrangement" can contain.

@astafan8 astafan8 changed the title Leakage sweep QDevil QDAC2: Leakage sweep Oct 17, 2022
@astafan8 astafan8 merged commit 37fabaa into QCoDeS:master Oct 17, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants