Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typechecking with pandas stubs #269

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

jenshnielsen
Copy link
Collaborator

Blueforce drivers depends on pandas but this was never added as a dependency.

Add pandas and pandas stubs as dependencies and fix issues with type checking against pandas stubs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (8f0eba2) 19.62% compared to head (16c1df0) 19.62%.

Files Patch % Lines
...codes_contrib_drivers/drivers/BlueFors/BlueFors.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   19.62%   19.62%   -0.01%     
==========================================
  Files         153      153              
  Lines       18768    18771       +3     
==========================================
  Hits         3684     3684              
- Misses      15084    15087       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
@astafan8 astafan8 merged commit 8ee76ec into QCoDeS:main Nov 20, 2023
8 checks passed
@jenshnielsen jenshnielsen deleted the pandas_stubs branch November 20, 2023 13:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants