-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QphoX - CryoSwitchController #337
Open
FKMalina
wants to merge
59
commits into
QCoDeS:main
Choose a base branch
from
FKMalina:CryoSwitchController
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odes_contrib_drivers into CryoSwitchController
…odes_contrib_drivers into CryoSwitchController
@astafan8 |
@astafan8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a QCoDeS driver for a QphoX cryogenic switch controller:
https://qphox.eu/switch_controller
The driver is created by making a copy of the QphoX SDK (https://github.com/QphoX/CryoSwitchController). The license allows it, but has a specific restrictions. For that reason the driver folder contains a copy of the QphoX license and readme files indicating which files come from the SDK, and which are the QCoDeS driver wrappers. This makes the code more convoluted by necessary, but I figured that keeping things clearly separated is the best way to comply with the license.
The SDK uses the files in the driver directory to keep track of the switch state. It's not beautiful. I did my best to ensure they are not synchronized by git. It is not a beautiful solution, but I did not want to make changes in the files from the QphoX SDK.
The drivers was checked by Cristobal Ferrer cristobal@qphox.eu from QphoX, so he can be pinged with some questions if needed.