Corrections to V7 transaction format and using updated test vectors #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…auth digest hash personalization)
vivek-arte
force-pushed
the
txv7-rebased-corrected
branch
2 times, most recently
from
1d17ea0
to
9107831
Compare
…fixes. Also making the zcash_unstable flag value consistent
vivek-arte
force-pushed
the
txv7-rebased-corrected
branch
from
9107831
to
9b67da5
Compare
alexeykoren
requested changes
Jul 19, 2024
alexeykoren
approved these changes
Jul 19, 2024
|
CI checks fail due to missing |
Right. Yes, we'll merge it soon. But this PR we can merge even before, given that we are not targeting zsa1 |
PaulLaux
approved these changes
Jul 23, 2024
| let tx = Transaction::read(&tv.tx[..], BranchId::Nu5).unwrap(); | ||
| let tx = Transaction::read( | ||
| &tv.tx[..], | ||
| #[cfg(not(zcash_unstable = "nu6"))] /* TODO nu7 */ BranchId::Nu5, |
There was a problem hiding this comment.
new line after /* TODO nu7 */ (all occurrences)
There was a problem hiding this comment.
cargo fmt pushes it back to the above line (so making it new line would make it fail the Rustfmt CI check).
There was a problem hiding this comment.
I confirmed that this is the case for all lines where the newline is not used.
…ng constant imports to ENC_CIPHERTEXT_SIZE
alexeykoren
pushed a commit
that referenced
this pull request
Jul 24, 2024
) This PR makes the following changes: - reordering of the component fields in `read_action` and `write_action` in issuance in order to make them spec compliant. - It sets some of the constant values for NU7 in a way that is consistent with the generated test vectors from the Python reference implementation (See QED-it/zcash-test-vectors#22 for the changes to the Python reference implementation). - Some changes are made to function names to reflect the shift from preparing ZSAs for V7 rather than V6. - There are changes to the tests to use the `zcash_unstable` flag in order to cover both ZSA and vanilla Orchard behavior. - The test vectors are also expanded to include both the V5 vectors, and the V7 vectors (behind a `zcash_unstable` flag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
read_actionandwrite_actionin issuance in order to make them spec compliant.zcash_unstableflag in order to cover both ZSA and vanilla Orchard behavior.zcash_unstableflag).