Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Rustfmt

use of `default` to create a unit struct: src/note/commitment.rs#L164

warning: use of `default` to create a unit struct --> src/note/commitment.rs:164:31 | 164 | let mut os_rng = OsRng::default(); | ^^^^^^^^^^^ help: remove this call to `default` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default

the borrowed expression implements the required traits: tests/zsa.rs#L202

warning: the borrowed expression implements the required traits --> tests/zsa.rs:202:33 | 202 | proven.apply_signatures(&mut rng, sighash, &[]).unwrap() | ^^^^^^^^ help: change this to: `rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: tests/zsa.rs#L94

warning: the borrowed expression implements the required traits --> tests/zsa.rs:94:27 | 94 | .apply_signatures(&mut rng, sighash, &[SpendAuthorizingKey::from(sk)]) | ^^^^^^^^ help: change this to: `rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

the borrowed expression implements the required traits: tests/zsa.rs#L81

warning: the borrowed expression implements the required traits --> tests/zsa.rs:81:17 | 81 | proven.sign(&mut rng, isk).unwrap() | ^^^^^^^^ help: change this to: `rng` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

returning the result of a `let` binding from a block: src/circuit.rs#L669

warning: returning the result of a `let` binding from a block --> src/circuit.rs:669:13 | 658 | / let nf_old = gadget::derive_nullifier( 659 | | layouter.namespace(|| "nf_old = DeriveNullifier_nk(rho_old, psi_old, cm_old)"), 660 | | config.poseidon_chip(), 661 | | config.add_chip(), ... | 666 | | nk.clone(), 667 | | )?; | |_______________- unnecessary `let` binding 668 | 669 | nf_old | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 658 ~ 659 | 660 ~ gadget::derive_nullifier( 661 + layouter.namespace(|| "nf_old = DeriveNullifier_nk(rho_old, psi_old, cm_old)"), 662 + config.poseidon_chip(), 663 + config.add_chip(), 664 + ecc_chip.clone(), 665 + rho_old.clone(), 666 + &psi_old, 667 + &cm_old, 668 + nk.clone(), 669 + )? |

returning the result of a `let` binding from a block: src/circuit.rs#L669