Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to TXID generation to account for ZSA additions #22

Merged
merged 36 commits into from
Sep 19, 2024
Merged

Changes to TXID generation to account for ZSA additions #22

merged 36 commits into from
Sep 19, 2024

Commits on Jun 18, 2024

  1. updating zip_0244 functions to support generating both V5 and V6 dige… 

    …sts, and adding NU6 constants to transaction.py
    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e1674dd View commit details
    Browse the repository at this point in the history

  2. adding V6 transaction class to transaction.py -- code reuse needs to … 

    …be improved
    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    e08b89c View commit details
    Browse the repository at this point in the history

  3. changes to transaction.py and zip_0244.py

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    97ba30d View commit details
    Browse the repository at this point in the history

  4. minor update

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9fbb1b0 View commit details
    Browse the repository at this point in the history

  5. initial attempt at inheritance, to be improved

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9f308ee View commit details
    Browse the repository at this point in the history

  6. changing inheritance structure of TransactionV5 and TransactionV6, an… 

    …d moving TransactionV6 to transaction_zsa.py
    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    4744106 View commit details
    Browse the repository at this point in the history

  7. reverting zip_0244.py to only include V5 details

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    26616ee View commit details
    Browse the repository at this point in the history

  8. separate txid vectors for zsa into separate files

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1130d66 View commit details
    Browse the repository at this point in the history

  9. adding ZSA version of zip 244 vectors

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    aea6de2 View commit details
    Browse the repository at this point in the history

  10. renaming to NU7 and so on

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1a2a58e View commit details
    Browse the repository at this point in the history

  11. still WIP, updating to work with librustzcash code

    @vivek-arte
    vivek-arte committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c33d00a View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. updating get_random_unicode_bytes to give a slightly wider range of v… 

    …alues
    @vivek-arte
    vivek-arte committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    49aeb58 View commit details
    Browse the repository at this point in the history

  2. changes to the transaction format serialization and the txid generati… 

    …on to make it spec compliant
    @vivek-arte
    vivek-arte committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    256c06f View commit details
    Browse the repository at this point in the history

  3. updating the generated test vectors

    @vivek-arte
    vivek-arte committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    029cfae View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. some cleanup changes

    @vivek-arte
    vivek-arte committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    cca44d8 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. removing unichr option from get_random_unicode_bytes

    @vivek-arte
    vivek-arte committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    2c5e31d View commit details
    Browse the repository at this point in the history

  2. cleaner import

    @vivek-arte
    vivek-arte committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    6bd821d View commit details
    Browse the repository at this point in the history

  3. simple changes based on review comments

    @vivek-arte
    vivek-arte committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    2ebe23d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. moving common transaction fields in a way that reduces code duplication

    @vivek-arte
    vivek-arte committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4ad2361 View commit details
    Browse the repository at this point in the history

  2. reducing code duplication by creating an OrchardActionBase class whic… 

    …h is inherited by OrchardActionDEscription and OrchardZSAActionDescription
    @vivek-arte
    vivek-arte committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    10ef794 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. reducing code duplication in transaction, transaction_zsa, zip_0244 a… 

    …nd zip_0244_zsa files
    @vivek-arte
    vivek-arte committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    59b0372 View commit details
    Browse the repository at this point in the history

  2. reducing code duplication inside the main function of zip_0244 and zi… 

    …p_0244_zsa
    @vivek-arte
    vivek-arte committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    df173c0 View commit details
    Browse the repository at this point in the history

  3. regenerating test vectors

    @vivek-arte
    vivek-arte committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    ea6e099 View commit details
    Browse the repository at this point in the history

  4. minor spacing fix to reduce diff

    @vivek-arte
    vivek-arte committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    0448e1e View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. resolving review comments, first pass

    @vivek-arte
    vivek-arte committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    7a48c13 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2024

  1. resolving review comments, second pass

    @vivek-arte
    vivek-arte committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    5cedbba View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. resolving review comments, third pass

    @vivek-arte
    vivek-arte committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    fcc4f94 View commit details
    Browse the repository at this point in the history

  2. updating test vector files

    @vivek-arte
    vivek-arte committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    62a239e View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. changing txn version back to V6

    @vivek-arte
    vivek-arte committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ede0e0a View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. resolving review comments

    @vivek-arte
    vivek-arte committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    de12205 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. renaming rho to nf_old in note_encryption files

    @vivek-arte
    vivek-arte committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    ea48161 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. making changes based on review

    @vivek-arte
    vivek-arte committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0409263 View commit details
    Browse the repository at this point in the history

  2. further changes

    @vivek-arte
    vivek-arte committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0d1e967 View commit details
    Browse the repository at this point in the history

  3. adding Offsets class, other review changes

    @vivek-arte
    vivek-arte committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1d936d1 View commit details
    Browse the repository at this point in the history

  4. removing redundant import

    @vivek-arte
    vivek-arte committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    737b366 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. based on review comments

    @vivek-arte
    vivek-arte committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ff64cde View commit details
    Browse the repository at this point in the history