Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage workflow and remove workflow dependency on coveragepy-lcov #597

Merged
merged 2 commits into from
May 22, 2024

Conversation

garrison
Copy link
Member

It looks like we no longer even need to coveragepy-lcov tool: nedbat/coveragepy#587 (comment)

@garrison
Copy link
Member Author

garrison commented May 22, 2024

I am beyond puzzled about why the coveralls upload suddenly stopped working, which is what originally motivated this PR. I found coverallsapp/github-action#207 (comment) but it looks like we are doing everything by the book.

@garrison
Copy link
Member Author

garrison commented May 22, 2024

I suspect the problem is coverallsapp/coverage-reporter#127. coverallsapp/coverage-reporter#127 (comment) provides a potential workaround.

@garrison garrison changed the title Attempt to fix coverage workflow Remove workflow dependency on coveragepy-lcov May 22, 2024
@garrison garrison changed the title Remove workflow dependency on coveragepy-lcov Fix coverage workflow and remove workflow dependency on coveragepy-lcov May 22, 2024
@garrison garrison marked this pull request as ready for review May 22, 2024 01:34
@garrison garrison merged commit 5fa3abc into main May 22, 2024
11 checks passed
@garrison garrison deleted the fix-coverage branch May 22, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant