Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in unsupported instructions error message #1005

Merged
merged 2 commits into from
Oct 27, 2020

Conversation

chriseclectic
Copy link
Member

Summary

Fixes bug in the error message returned when a circuit contains unsupported simulator instructions. Previously some supported instructions were also being listed in the error message along with the unsupported instructions.

Fixes #1004

Details and comments

Fixes bug in how sets of unsupported instructions were constructed. The previous method didn't work properly with std::unordered_set.

Fixes bug in how sets of unsupported instructions were constructed. The previous method didn't work properly with std::unordered_set.
@chriseclectic chriseclectic added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the Fixed section of the changelog labels Oct 27, 2020
Copy link
Contributor

@vvilpas vvilpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch about unordered_sets and set_difference.

src/framework/opset.hpp Outdated Show resolved Hide resolved
Copy link
Contributor

@vvilpas vvilpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vvilpas vvilpas merged commit 33f1315 into Qiskit:master Oct 27, 2020
chriseclectic added a commit to chriseclectic/qiskit-aer that referenced this pull request Nov 12, 2020
Fixes bug in how sets of unsupported instructions were constructed. The previous method didn't work properly with std::unordered_set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New errors about invalid instructions for the MPS simulator
2 participants