Fix param positions for circuits with conditionals #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this solves #1849 so I think after adding a test it can be merged |
doichanj
reviewed
Jul 6, 2023
| @@ -441,22 +461,28 @@ def test_check_parameter_binds_exist(self): | |||
|
|
|||
| def test_global_phase_parameters(self): | |||
| """Test parameterized global phase""" | |||
| backend = AerSimulator() | |||
| backend = AerSimulator(method="extended_stabilizer") | |||
There was a problem hiding this comment.
Is it enough only testing extended_stabilizer?
There was a problem hiding this comment.
Yes. We do not know practical cases to use parameterized global phases without extended_stabilizer. From the implementation perspective, parameters for global phases are resolved in common part for any methods.
doichanj
approved these changes
Jul 6, 2023
hhorii
added
the
stable-backport-potential
hhorii
added a commit
to hhorii/qiskit-aer
that referenced
this pull request
Jul 7, 2023
* fix parameter indexing issues. * fix issues in parameterization of global phase * add reno * fix lint * fix release note * fix a bug to call _convert_circuit_binds * add test
hhorii
added a commit
that referenced
this pull request
Jul 12, 2023
* bump version strings and prepare for release * Remove `AerCircuit` from result of `backend.run()` (#1845) * take AerCircuit from _metadata in experiment result * add reno * Fix rST formatting --------- Co-authored-by: Jake Lishman <jake@binhbar.com> * pin numpy version lower than 1.25 (#1859) * Fix param positions for circuits with conditionals (#1851) * fix parameter indexing issues. * fix issues in parameterization of global phase * add reno * fix lint * fix release note * fix a bug to call _convert_circuit_binds * add test * Support save_statevector for QuantumCircuit from QASM3 string (#1846) * Support save_statevector for QuantumCircuit from QASM3 string * add qiskit_qasm3_import to requirements-dev.txt * simplify default_qubits() * fix lint error * skip qasm3 circuit test in 3.7 * New GPU binaries with cuQuantum support (#1854) * New GPU binaries with cuQuantum support * format setup.py * remove testpipy settings * Update setup.py to use numpy with version lower than 1.25 * changed package names, qiskit-aer-gpu for CUDA12, and qiskit-aer-gpu-cu11 for 11 * format setup.py * Update README.md Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * Update releasenotes/notes/renew_gpu_binaries-2cf3eba0853b8407.yaml Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * update release note --------- Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org> * bump up python version from 3.7 to 3.8 to run cibuildwheel (#1867) * bump up python version from 3.7 to 3.8 to run cibuildwheel * bump up all python version in deploy workflow * add reno * set numpy version constraint only in dev (#1871) * add numpy version constraint only in dev * set numpy version constraint in contraints.txt * bump up version in docs --------- Co-authored-by: Jake Lishman <jake@binhbar.com> Co-authored-by: Jun Doi <doichan@jp.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #1849
Details and comments
When conditional gates exist, parameter positions are changed because
bfuncoperations are injected.It is the root cause of #1849 that reports wrong parameter bindings with circuits that have conditional gates.
With this PR, positions of Qiskit instructions and Aer operations are mapped and Aer's parameter bindings are based on this mapping.
Also this PR fixes a bug in parameterization of global phases, which was introduced in #1814. Its implementation was not correct and a test was not enough.