Add HamiltonianModel class for configuring PulseSimulator #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class contains the Hamiltonian portions of OPSystem and digest
chriseclectic
added
the
PulseSimulator
DanPuzzuoli
approved these changes
Dec 12, 2019
| ground_state += estate_coef * op.basis(len(self._evals), idx) | ||
| return ground_state | ||
|
|
||
| def calculate_frequencies(self, qubit_lo_freq=None, u_channel_lo=None): |
There was a problem hiding this comment.
I think the name of this is good for this iteration. Something that might make sense next, as we refactor so that OPSystem holds a HamiltonianModel, is to break this function up: one (or several) in HamiltonianSystem that compute eigenvectors/eigenvalues/dressed energies for the drift Hamiltonian, and then another in OPSystem called something like channel_frequencies, which, if passed the argument from_hamiltonian will draw the relevant info from HamiltonianModel.
atilag
approved these changes
Dec 12, 2019
DanPuzzuoli
reviewed
Dec 12, 2019
DanPuzzuoli
reviewed
Dec 12, 2019
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Add HamiltonianModel class for pulse simulator * update digest to use HamiltonianModel * change statevector pulse tests to use state_fidelity
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Add HamiltonianModel class for pulse simulator * update digest to use HamiltonianModel * change statevector pulse tests to use state_fidelity
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Add HamiltonianModel class for pulse simulator * update digest to use HamiltonianModel * change statevector pulse tests to use state_fidelity
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jan 23, 2020
* Add HamiltonianModel class for pulse simulator * update digest to use HamiltonianModel * change statevector pulse tests to use state_fidelity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
HamiltonianModelclass to store the hamiltonian configuration parts of theOPSystemclass and hamiltonian utility functions from pulse qobj digest.Details and comments
Currently I just refactored digest to use this class without actually modifying
OPSystem(it builds the HamiltonianModel, then copies entries back to OPSystem) so as to minimize code changes. In a future PR this could be refactored so OPSystem stores the HamiltonianModel.The pulse utility functions should also be refactored (or removed) to use this class.