MPS: Support multi-qubit apply matrix #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot in ascending order
…dered in ascending order
…n consecutive order
… documentation accordingly
atilag
reviewed
Feb 25, 2020
| case 2: | ||
| apply_2_qubit_gate(qubits[0], qubits[1], su4, mat); | ||
| break; | ||
| // case 2: |
There was a problem hiding this comment.
Just remove these lines, no need for commenting.
src/simulators/matrix_product_state/matrix_product_state_internal.cpp
Outdated
Show resolved
Hide resolved
atilag
approved these changes
Feb 26, 2020
mtreinish
pushed a commit
to mtreinish/qiskit-aer
that referenced
this pull request
Mar 2, 2020
* added support for computing expectation value pauli when qubits are not in ascending order * in expectation_value_pauli, moved the reverse_qubits to before the sort * update MPS expectation value snapshots * added support for expectation value matrix when the qubits are not ordered in ascending order * rewrote the function move_qubits_to_new_position * fixed bug in the optimization for the case where the qubits are given in consecutive order * changed name of method and parameters, to suit functionality * updated documentation accordingly * added support for multi-qubit apply_matrix Co-authored-by: yaelbh <yaelbh@il.ibm.com> (cherry picked from commit 150f405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enabled applying unitary matrices on more than 2 qubits.
Details and comments
This PR uses developments from PR #603, so must be merge after merging #603.