Fixed cz gate of DensityMatrixThrust #754 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
stable-backport-potential
|
I added this to PR #765 which fixes the tests which werent being run for density matrix simulator and it looks like a couple are still failing |
|
Sorry I removed cmake files. Also I fixed cz gate again. Using apply_diagonal_matrix instead of apply_matrix |
chriseclectic
removed
the
stable-backport-potential
chriseclectic
added
the
stable-backport-potential
chriseclectic
approved these changes
May 30, 2020
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
May 30, 2020
* fixed cz and y gates of DensityMatrixThrust Qiskit#754 Co-authored-by: Christopher Wood <cjwood@us.ibm.com>
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in Qiskit#760
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in Qiskit#760
chriseclectic
added a commit
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in #760
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in Qiskit#760
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
* fixed cz and y gates of DensityMatrixThrust Qiskit#754 Co-authored-by: Christopher Wood <cjwood@us.ibm.com>
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in Qiskit#760
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
* fixed cz and y gates of DensityMatrixThrust Qiskit#754 Co-authored-by: Christopher Wood <cjwood@us.ibm.com>
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Jun 1, 2020
Fixes a bug introduced in Qiskit#760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I modified cz gate implementation of DensityMatrixThrust class to fix issue #754
I noticed y gate also has issue so I fixed it.
Details and comments
The matrix to be applied by apply_matrix in cz gate was wrong, diagonal elements should be set to 1 but set to 0.
Also the matrix set in y gate was wrong, I created separate kernel for y gate.