Add BLAS_LIB_PATH as ENV var #822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As |
|
I like putting AER prefix to our variables, so we can make distinction between our variables and thoe potentially used in our third-party build system deps. |
vvilpas
force-pushed
the
build/openblas_lib_env
branch
from
7f4b5ee
to
3b675db
Compare
atilag
approved these changes
Jul 22, 2020
gadial
pushed a commit
to gadial/qiskit-aer
that referenced
this pull request
Jul 23, 2020
* AER_BLAS_LIB_PATH as env var * Update contributing guide
chriseclectic
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pass BLAS_LIB_PATH to the build system as ENV variable. This will help solving issues around OpenBlas compilation, as it seems to be sometimes problematic when binary lib is not available at Conan and compilation is triggered.
Details and comments