Fix evaluation y expectation #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm having a hard time figuring out what did you actually change, there seems to be a lot of formatting changes but not changes in the logic? (apart from tests). |
|
Thanks for the review. The second commit is adding the test, and |
yaelbh
previously approved these changes
Aug 26, 2020
chriseclectic
requested changes
Aug 26, 2020
There was a problem hiding this comment.
Thanks for finding and fixing this bug @ikkoham. Could you add a release note so that this fix shows up in the changelog for the next release?
chriseclectic
added
Changelog: Bugfix
|
I've added a release note. |
chriseclectic
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix first part of #895.
I think this needs more tests.
I will write later.I have written it.