-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a generic "JoinServer" function #693
Conversation
This builds on top of #688, right? |
it does |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some formatting and optimisations
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
ty. most of the code with the bad formatting was code i took from elsewhere in the file. printing the server password really is a bad idea though. i don't know why i did that |
….nut Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
….nut Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Co-authored-by: Jack <66967891+ASpoonPlaysGames@users.noreply.github.com>
Northstar.Client/mod/scripts/vscripts/ui/menu_ns_serverbrowser.nut
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good now :)
Merge conflicts atm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked!
test by using the function in compartya
altought perhaps there should be a JoinServerByName
added in a later pr so that it would be easier to call from plugins :)
Thanks for testing @catornot @Klemmbaustein can you resolve merge conflicts so that we can consider merging? ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good as well so good to go!
Aight this is basically ready to merge. Will be in |
This reverts commit e4b3cc7.
Adds a function that allows the client to join a server from a ServerInfo struct.
This also changes the server browser to use this function. I have not tested if joining a server with a password works, but it should.
As an example, this is how you'd join a specific server by name: