Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LD_LIBRARY_PATH note to use-cpp documentation #197

Open
wants to merge 2 commits into
base: amd-staging
Choose a base branch
from
Open

Add LD_LIBRARY_PATH note to use-cpp documentation #197

wants to merge 2 commits into from

Conversation

peterjunpark
Copy link

@peterjunpark peterjunpark commented Sep 16, 2024 •
edited
Loading

  • Adds note to "Using C++" and "Using Python" documentation.

Note

hipcc and other compilers will not automatically link in the librocm_smi64 dynamic library. To ensure the librocm_smi64.so can be located, you must either set the LD_LIBRARY_PATH environment variable to the directory containing librocm_smi64.so (usually /opt/rocm/lib) or pass the -lrocm_smi64 flag to the compiler.

  • Fixes some weird formatting in docs
  • mv use-python.md to use-python.rst

@peterjunpark peterjunpark marked this pull request as ready for review September 16, 2024 17:37
@peterjunpark
fix formatting
a1f30c1 
fix fmt

fix fmt

impr toc

fix link
jamesxu2
jamesxu2 approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@jamesxu2 jamesxu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesxu2 jamesxu2 jamesxu2 approved these changes

@bill-shuzhou-liu bill-shuzhou-liu Awaiting requested review from bill-shuzhou-liu bill-shuzhou-liu is a code owner

@dmitrii-galantsev dmitrii-galantsev Awaiting requested review from dmitrii-galantsev dmitrii-galantsev is a code owner

@charis-poag-amd charis-poag-amd Awaiting requested review from charis-poag-amd charis-poag-amd is a code owner

@oliveiradan oliveiradan Awaiting requested review from oliveiradan oliveiradan is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjunpark @jamesxu2