Correct rocprofv2 help message. #122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change sorting so that it works with Python 3.x too
Change-Id: Ie727424eae47502395e0779614bd5e863ed9a197
Change-Id: Ieb6f98bec97e9d24ff6acc52b131a1a1a129a829
Change-Id: I87bc09ea8d2f903cafc0291f3565fd626254e475
Using clang-tidy with out any absolute path is resulting in build failure. Corrected the same. Due to build script issues, find_program was not able to find clang-tidy So the issue was not exposed. Fixing the build script exposed the build failures Change-Id: I6e886bf6beba531b97205f264f729544fd5cf303
Change-Id: I49656c0383782c69cc88eb6d874727149375b32c
Change-Id: Iea2475772f43f56125dd2cb0e4280fb0555ed7ad
The lifetime of the kernel descriptor handle is unknown, so we currently uses the record id to identify the kernel name Change-Id: I8802ce245bb021bcb43dd97cd6334bc88de0faf4
V1 library will be supported as librocprofiler64.so and V2 will be supported as librocprofiler64v2.so and headers will be rocprofiler.h for V1 and v2/rocprofiler.h for v2 Change-Id: Ibe5bdbf2f79f0175342c648e917ae77918186604
Change-Id: I70534fd136301e54416d5f663e52b57788a7ec0a (cherry picked from commit 3fd8de6)
Change-Id: I1c0b4d0d94565309490163e73a4866264bd5e67f
ROCm release v5.6.0
HIP/HSA are now correct in all trace options.
|
@ammarwa let me know your thoughts - checks failed but that seems unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIP/HSA are now correct in all trace options.