Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ExplosmBridge] Rewrite to work without feedburner #2417

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

jNullj
Copy link
Contributor

@jNullj jNullj commented Jan 8, 2022

re-wrote the bridge to scrap from the new explosm site as the old method of using feedburner is not working anymore, feedburner is stuck on dec/22 when the explosm site changed.

fix issue #2415

re-wrote the bridge to scrap from the new explosm site as the old method of using feedburner is not working anymore, feedburner is stuck on dec/22 when the explosm site changed.
@jNullj
Copy link
Contributor Author

jNullj commented Jan 8, 2022

I tested this on my own host with latest release and it works as intended (docker on archlinux host, tested with tt-rss as client)

@em92
Copy link
Contributor

em92 commented Jan 9, 2022

Ping @Bockiii for reviewing this change.

Copy link
Contributor

@em92 em92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @jNullj!
Please fix linting and comment below.

Comment on lines 14 to 16
'required' => true,
'title' => 'Maximum number of items to return',
'defaultValue' => 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need "required" here?
This setting will break previous usage, where "/?action=display&bridge=Explosm&format=Html" worked. If I apply this change, users need to reedit their rss feeds.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not think about it, this is a great insight. I makred it required becouse a limit is required. I could make it so the default is 5 which is the number of posts the bridge returned when it used feedburner before this change. Does the 'defaultValue' => 5 will take care of that, im not sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested myself, i fixed this and tested for old feed urls to work.

For backwards compatibility with links used by the previous version of this bridge assume default of 1 posts if the parameter is missing.
@teromene teromene merged commit 799c93a into RSS-Bridge:master Jan 10, 2022
@Bockiii
Copy link
Contributor

Bockiii commented Jan 10, 2022

Wasn't able to test this until now, but it looks like it works well. Thanks @jNullj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants