Skip to content

Commit

Permalink
fix: Mention partial matches are not hidden. Break apart 'about' pref…
Browse files Browse the repository at this point in the history
…erence into two sections to reduce text clipping of translations
  • Loading branch information
LisoUseInAIKyrios committed Aug 28, 2024
1 parent 6c94839 commit d982bc0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ object HideLayoutComponentsPatch : BytecodePatch(
SwitchPreference("revanced_hide_keyword_content_search"),
TextPreference("revanced_hide_keyword_content_phrases", inputType = InputType.TEXT_MULTI_LINE),
NonInteractivePreference("revanced_hide_keyword_content_about"),
NonInteractivePreference("revanced_hide_keyword_content_limitations"),
),
),
)
Expand Down
13 changes: 8 additions & 5 deletions src/main/resources/addresources/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,16 @@ This is because Crowdin requires temporarily flattening this file and removing t
<string name="revanced_hide_keyword_content_search_summary_off">Search results are not filtered by keywords</string>
<string name="revanced_hide_keyword_content_phrases_title">Keywords to hide</string>
<!-- For localization it is preferred, but not required, if 'LeBlanc' is replaced with a localized name or a familiar word that has upper case letters in the middle of the word.
This is because keywords can be in any language, and showing an example in the localized script helps convey this. -->
<string name="revanced_hide_keyword_content_phrases_summary">Keywords and phrases to hide, separated by new lines\n\nWords with uppercase letters in the middle must be entered with the casing (ie: iPhone, TikTok, LeBlanc)</string>
This is because keywords can be in any language, and showing an example in the localized script helps convey this.
Do not translate using 'fox' or 'foxes'. Instead use a localized pair of words where the first keyword is a substring of the second (and both words refer to the same thing/idea). If the language does not have any examples of this (such as some pictographic languages) then do not include that info in the translation. -->
<string name="revanced_hide_keyword_content_phrases_summary">Keywords and phrases to hide, separated by new lines\n\nWords with uppercase letters in the middle must be entered with the casing (ie: iPhone, TikTok, LeBlanc)\n\nVideo with partial word matches are not hidden and some keywords may need additional variations (ie: if adding keyword \'fox\' then also add \'foxes\')</string>
<string name="revanced_hide_keyword_content_about_title">About keyword filtering</string>
<string name="revanced_hide_keyword_content_about_summary">Home/Subscription/Search results are filtered to hide content that matches keyword phrases\n\nLimitations\n• Some Shorts may not be hidden\n• Some UI components may not be hidden\n• Searching for a keyword may show no results</string>
<string name="revanced_hide_keyword_content_about_summary">Home/Subscription/Search results are filtered to hide content that matches keyword phrases\n\nKeywords can be a channel name or any text shown in video titles</string>
<string name="revanced_hide_keyword_content_limitations_title">Limitations</string>
<string name="revanced_hide_keyword_content_limitations_summary">• Some Shorts may not be hidden\n• Some UI components may not be hidden\n• Searching for a keyword may show no results</string>
<!-- Translations of this should not be longer than the original English text, otherwise the text can be clipped and not entirely shown. -->
<string name="revanced_hide_keyword_toast_invalid_common">Cannot use: \'%s\' as a keyword</string>
<string name="revanced_hide_keyword_toast_invalid_broad">Keyword \'%s\' will hide all videos</string>
<string name="revanced_hide_keyword_toast_invalid_common">Cannot use keyword: \'%s\'</string>
<string name="revanced_hide_keyword_toast_invalid_broad">Keyword will hide all videos: \'%s\'</string>
</patch>
<patch id="ad.general.HideAdsResourcePatch">
<string name="revanced_hide_general_ads_title">Hide general ads</string>
Expand Down

0 comments on commit d982bc0

Please sign in to comment.