Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Spoof client): Fix tracking history on brand accounts #3480

Merged
merged 2 commits into from
Jul 28, 2024

Conversation

oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX commented Jul 28, 2024

@oSumAtrIX oSumAtrIX force-pushed the fix/spoof-client-watch-history branch from 45a5281 to 9e7d25c Compare July 28, 2024 13:00
@LisoUseInAIKyrios
Copy link
Contributor

Can also remove the limitation from the setting summary disclaimer

@oSumAtrIX oSumAtrIX merged commit 69c1f16 into dev Jul 28, 2024
2 checks passed
@oSumAtrIX oSumAtrIX deleted the fix/spoof-client-watch-history branch July 28, 2024 13:54
revanced-bot pushed a commit that referenced this pull request Jul 28, 2024
# [4.12.0-dev.9](v4.12.0-dev.8...v4.12.0-dev.9) (2024-07-28)

### Bug Fixes

* **YouTube - Spoof client:** Fix tracking history on brand accounts ([#3480](#3480)) ([69c1f16](69c1f16))
@MarcaDian

This comment was marked as off-topic.

@n1cKz1
Copy link

n1cKz1 commented Jul 31, 2024

I just patched dev and tested briefly, apparently history still isn't tracking for me

@LisoUseInAIKyrios
Copy link
Contributor

@n1cKz1 is stock YT showing your history?

A DNS ad blocker can interfere with playback history.

@oSumAtrIX
Copy link
Member Author

Use a network debugger with the network debugging patch and check if the patch has successfully changed the request urls authority

@n1cKz1
Copy link

n1cKz1 commented Jul 31, 2024

Will do later once I get home.

I do use adguard but the patched app is whitelisted. History tracks fine when spoofing is off.

@n1cKz1
Copy link

n1cKz1 commented Jul 31, 2024

check if the patch has successfully changed the request urls authority

I tested with spoof client on and off to check for any differences in the traffic and there wasn't any. Double checked that AdGuard isn't at fault, history also works with VR spoofing as expected.

Luckily for some reason I'm still unaffected by the playback issue so I'll keep spoofing off for now.

@oSumAtrIX
Copy link
Member Author

Which authority was present?

@n1cKz1

This comment was marked as outdated.

@oSumAtrIX
Copy link
Member Author

You are interested in the watch history requests. So those that have api/stats in their path.

@n1cKz1
Copy link

n1cKz1 commented Aug 1, 2024

Spoofing on:
image

Spoofing off:
image

revanced-bot pushed a commit that referenced this pull request Aug 6, 2024
# [4.12.0](v4.11.0...v4.12.0) (2024-08-06)

### Bug Fixes

* **Google Photos - GmsCore support:** Fix by checking first if a method exists before trying to patch it ([acf38ca](acf38ca))
* **Instagram - Hide ads:**  Restore compatibility with latest version by fixing fingerprint ([#3455](#3455)) ([4505fa4](4505fa4))
* **Messenger - Disable switching emoji to sticker:** Constrain to last working version `439.0.0.29.119` ([6207c31](6207c31))
* **SoundCloud - Enable offline sync:** Stop crashing by reversing order of patching instructions from last to first to retain indices ([63b6ced](63b6ced))
* **YouTube - Bypass image region restrictions:** Move setting to `Misc` menu ([094ae59](094ae59))
* **YouTube - Client Spoof:** Restore missing high qualities by spoofing the iOS client user agent ([#3468](#3468)) ([0e6ae5f](0e6ae5f))
* **YouTube - Hide keyword content:** Do not hide flyout menu ([687c9f7](687c9f7))
* **YouTube - SponsorBlock:** Correctly show minute timestamp when creating a new segment ([d74c366](d74c366))
* **YouTube - SponsorBlock:** Improve create segment manual seek accuracy ([#3491](#3491)) ([1544981](1544981))
* **YouTube - Spoof client:** Fix tracking history on brand accounts ([#3480](#3480)) ([69c1f16](69c1f16))
* **YouTube - Spoof client:** Restore livestream audio only playback with iOS spoofing ([#3504](#3504)) ([90d3288](90d3288))

### Features

* Add `Hide mock location` patch ([#3417](#3417)) ([5f81b40](5f81b40))
* Add `Spoof build info` patch ([e7829b4](e7829b4))
* **Boost for Reddit:** Add `Disable ads` patch ([#3474](#3474)) ([b292c20](b292c20))
* **CandyLink:** Remove non-functional `Unlock pro` patch ([7ae9f8f](7ae9f8f))
* **Expense Manager:** Remove non-functional `Unlock pro` patch ([ebbcac7](ebbcac7))
* **Google News:** Add `Enable CustomTabs` and `GmsCore support` patch ([#3111](#3111)) ([ad59096](ad59096))
* **Google Photos:** Add `GmsCore support` patch ([#3414](#3414)) ([24528e0](24528e0))
* **Instagram:** Remove unnecessary `Hide timeline ads` patch ([5e1d001](5e1d001))
* **SoundCloud:** Add `Enable offline sync` patch ([#3407](#3407)) ([4de86c6](4de86c6))
* **SwissID:** Add `Remove Google Play Integrity Integrity check` patch ([#3478](#3478)) ([60492ae](60492ae))
* **YouTube - Description components:** Add `Hide 'Key concepts' section` option ([#3495](#3495)) ([d75b645](d75b645))
* **YouTube:** Add `Bypass image region restrictions` patch ([#3442](#3442)) ([765fab2](765fab2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(YouTube): Spoof client patch - various side effects (watch history, auto resume playback, ...)
4 participants