-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to OpenBabel 3 #451
Conversation
d8705e4
to
1ed7008
Compare
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
- Coverage 54.55% 54.51% -0.05%
==========================================
Files 39 39
Lines 12180 12180
Branches 3750 3750
==========================================
- Hits 6645 6640 -5
- Misses 4528 4532 +4
- Partials 1007 1008 +1
Continue to review full report at Codecov.
|
- specified cclib version - decreased matplotlib version - removed mock - added muq2 - decreased numpy - removed constraints from pandas - added xlrd
Only run Py3.7
@mefuller, this PR is now ready for review, please take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Environment builds faster; uniform with RMG; updates to tests are iffy without further inspection, but assume ok for now as tests pass
Thanks @mefuller! |
This is a twin PR for ReactionMechanismGenerator/RMG-Py#2088