Discussion: what does a typical performance run look like?

[staltz]

I ran the performance scripts, and I'm not sure if they ran correctly, because I get a lot of zeroes on this table (while Chrome opened and tests seemed to be running):

> @reactivex/rxjs@0.0.0-prealpha.3 perf /Users/amed/Hobby/RxJSNext
> protractor protractor.conf.js

Using ChromeDriver directly...
[launcher] Running 1 instances of WebDriver
Started
BENCHMARK bufferCount Rx2
Description:
- forceGc: false
- iterations: 1000
- regressionSlopeMetric: scriptTime
- sampleSize: 20
- userAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/45.0.2454.93 Safari/537.36
Metrics:
- gcAmount: gc amount in kbytes
- gcTime: gc time in ms
- majorGcTime: time of major gcs in ms
- pureScriptTime: script execution time in ms, without gc nor render
- renderTime: render time in ms
- scriptTime: script execution time in ms, including gc and render

          gcAmount |             gcTime |        majorGcTime |     pureScriptTime |         renderTime |         scriptTime
------------------ | ------------------ | ------------------ | ------------------ | ------------------ | ------------------
              0.00 |               0.00 |               0.00 |               0.00 |               0.22 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.08 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.11 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.43 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.08 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.31 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.19 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.33 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.15 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.16 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.18 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.16 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.09 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.34 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.28 |               0.00
              0.00 |               0.00 |               0.00 |               0.00 |               0.08 |               0.00
================== | ================== | ================== | ================== | ================== | ==================
              0.00 |               0.00 |               0.00 |               0.00 |          0.18+-59% |               0.00

I have not setup my development environment like you have. For instance, I didn't have protractor installed globally (it's a devDependency, so it's already installed locally). Instead I ran ./node_modules/.bin/webdriver-manager update and ./node_modules/.bin/webdriver-manager start prior to running npm run perf. I also didn't have a http-server installed globally since it's also a devDependency. If the output of that table above looks correct, then I can update the instructions in README.md to be less susceptible on "works-on-my-computer" issues. Relying on locally installed binaries is safer (also against version mismatch problems).

[staltz]

Also, I don't see why it's necessary to start http-server in the home directory. npm run perf seems to run normally without it, because protractor.config.js has this:

  beforeLaunch: function () {
    httpServer.createServer({
      showDir: false
    }).listen('8080', 'localhost');
  },

I guess README.md is simply outdated?

[kwonoj]

I think README.md is somewhat outdated.

For test results, mentioned bit in #263 and #280 that benchpress need to be updated once its new version is available.

[benlesh]

@staltz There was a change in Chrome that broke Benchpress.

[benlesh]

@jeffbcross did give me a .zip of a newer version that should fix it, I just have been too busy to add it in.

[benlesh]

... and yes, the README might be a little outdated.

[staltz]

Ok, I'll send a small PR to update the README, and wait for a Chrome fix.

[benlesh]

Closing for #348