chore(test): add macro performance tests for zip #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May I possibly ask blocked label means? Does PR have issues need to be addressed? |
|
No.. your PR is fine. There's an issue with the macro perf tests and the latest version of Chrome. |
|
In other words, you're blocked by @jeffbcross! :P haha. |
|
.... actually, I guess I can merge this and verify later, since it's not in the critical path and won't cause Travis to fail. |
|
Thanks for clarification, much appreciated. :) |
Welcome to the Blocked By @jeffbcross Club! |
|
😃 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to create macro test to close #259