Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): move Symbol.observable into types.ts #6178

Merged
merged 1 commit into from
Mar 28, 2021

Conversation

cartant
Copy link
Collaborator

@cartant cartant commented Mar 26, 2021

Note that this PR targets the 6.x branch.

Description:

This PR moves the declaration merging associated with Symbol.observable from internal/symbol/observable.ts to internal/types.ts - which is where it's located in the v7 codebase. This fixes the problem raised in #6175.

Related issue (if exists): #6175

@benlesh benlesh merged commit 94f690b into ReactiveX:6.x Mar 28, 2021
kwonoj pushed a commit that referenced this pull request Apr 15, 2021
benlesh pushed a commit that referenced this pull request Apr 15, 2021
* fix(symbol): revert unique symbol in #5874

- closes #5919

* fix(types): move Symbol.observable into types.ts (#6178)

Closes #6175

Co-authored-by: Nicholas Jamieson <nicholas@cartant.com>
@cartant cartant deleted the cartant/issue-6175 branch April 18, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants