Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow (temporarily) exit codes 0 and 1 for regstatus, cvstatus and add (with incorrect PCR banks) #404

Merged

Conversation

maugustosilva
Copy link
Contributor

@maugustosilva maugustosilva commented Jun 30, 2023

`add` (with incorrect PCR banks)

Signed-off-by: Marcio Silva <marcio.a.silva@ibm.com>
@maugustosilva
Copy link
Contributor Author

/packit retest-failed

@maugustosilva
Copy link
Contributor Author

@kkaarreell @ansasaki Looks like a "cascading failure" starting at the install_upstream_rust_keylime

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
:: [ 20:06:13 ] :: [   FAIL   ] :: Command 'RUSTFLAGS='-Cinstrument-coverage' cargo build' (Expected 0, got 101)
:: [ 20:06:13 ] :: [  BEGIN   ] :: Running 'make install'
cargo build --target-dir="target" 
warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
   Compiling proc-macro2 v1.0.54
   Compiling quote v1.0.26
   Compiling unicode-ident v1.0.4
   Compiling libc v0.2.142
error[E0635]: unknown feature `proc_macro_span_shrink`
  --> /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.54/src/lib.rs:92:30
   |
92 |     feature(proc_macro_span, proc_macro_span_shrink)
   |                              ^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0635`.
error: could not compile `proc-macro2` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...
make: *** [GNUmakefile:26: target/debug/keylime_agent] Error 101
:: [ 20:06:13 ] :: [   FAIL   ] :: Command 'make install' (Expected 0, got 2)
:: [ 20:06:13 ] :: [  BEGIN   ] :: Running 'mkdir -p /etc/keylime/agent.conf.d'
:: [ 20:06:13 ] :: [   PASS   ] :: Command 'mkdir -p /etc/keylime/agent.conf.d' (Expected 0, got 0)
:: [ 20:06:13 ] :: [  BEGIN   ] :: Running 'cat > /etc/keylime/agent.conf.d/tpm_hash_alg.conf <<_EOF

@maugustosilva
Copy link
Contributor Author

/packit retest-failed

@kkaarreell
Copy link
Collaborator

@maugustosilva I agree. Let's wait a few days to see if @ansasaki makes a progress with the issue.

@ansasaki
Copy link
Contributor

ansasaki commented Jul 5, 2023

/packit retest-failed

@ansasaki
Copy link
Contributor

ansasaki commented Jul 5, 2023

Apparently the compilation issue is the same issue as described in rust-lang/rust#113152

This is due to the usage of nightly rust compiler (needed for the test coverage measurement). If I understood the issue correctly, the proc-macro2 crate used a feature that was removed in the nightly compiler in rust-lang/rust#111571. The issue should be fixed on proc-macro2 1.0.60+ by dtolnay/proc-macro2#391.

I'll try to bump the version on rust agent side.

@kkaarreell
Copy link
Collaborator

/packit test

@kkaarreell kkaarreell merged commit 8ffd7ed into RedHat-SP-Security:main Jul 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants