Adjust heartbeat behavior #180
Open
+77
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`jl_print_task_backtraces()` can take long enough that there can be heartbeat loss, which can trigger printing task backtraces again, unless it is called from the heartbeat thread which takes care of that possible problem.
github-actions
bot
added
port-to-v1.10
NHDaly
reviewed
Sep 19, 2024
Comment on lines
+1179
to
+1181
| if (!jl_inside_heartbeat_thread()) { | ||
| jl_heartbeat_pause(); | ||
| } |
There was a problem hiding this comment.
🤔 Why the if-check?
If a heartbeat loss causes us to print backtraces, could the backtraces we're printing cause another heartbeat loss?
I think I remember you said the answer is "no" when we discussed over zoom, but it would be nice to clarify that in the comments, here.
There was a problem hiding this comment.
I thought I'd written that up. Sorry, I'll add a comment. If this is called from the heartbeat thread, there will be no additional heartbeat loss because it is the heartbeat thread itself that determines whether there is heartbeat loss. So when it returns from here, the counter for heartbeats missed is unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Introduce a heartbeat pause/resume capability. Use this capability:
Checklist
Requirements for merging:
port-to-*labels that don't apply.