Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove spurious gc_try_claim_and_push #75

Merged
merged 1 commit into from
Sep 27, 2023
Merged

remove spurious gc_try_claim_and_push #75

merged 1 commit into from
Sep 27, 2023

Conversation

d-netto
Copy link
Member

@d-netto d-netto commented Sep 25, 2023

PR Description

Shouldn't affect correctness and should have a minimal effect on performance. We already fixed this upstream in JuliaLang#49780.

Checklist

Requirements for merging:

@kpamnany kpamnany merged commit 9bab9f4 into v1.9.2+RAI Sep 27, 2023
1 check passed
@kpamnany kpamnany deleted the dcn-gc-fix branch September 27, 2023 15:23
@nickrobinson251
Copy link
Member

@d-netto please can you set the port-to-* labels as appropriate? (sorry, this PR was opened before i'd got them up and running)
let me know if you've questions!

@d-netto
Copy link
Member Author

d-netto commented Sep 27, 2023

We merged this before the 1.10 feature freeze. So given that we've already backported to 1.9, then the ports to 1.10 and master might not be necessary? Not sure though.

@kpamnany
Copy link
Collaborator

kpamnany commented Sep 27, 2023

I think we still need the port to 1.9 label because this has to be backported to 1.9.3 when we upgrade to that.

If it's in 1.10 upstream then I think you're right that we don't need that label or the one for master.

@nickrobinson251
Copy link
Member

nice that it's in 1.10!

yeah, exactly as Kiran says, unless it's backported to v1.9 upstream, we need port-to-1.9 label

@d-netto d-netto added the port-to-v1.9 This change should apply to Julia v1.9 builds label Sep 27, 2023
@kpamnany kpamnany removed the port-to-v1.9 This change should apply to Julia v1.9 builds label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants