fix: adding missing tests related to subtype addition

src/hrflow_connectors/core/connector.py

@@ -774,9 +774,11 @@ class ConnectorModel(BaseModel):
     def check_subtype(cls, value: str) -> str:
         cleaned_value = value.lower()
         if cleaned_value != value:
-            raise ValueError("ConnectorModel's `subtype` must be lowercase.")
+            raise ValueError(f"ConnectorModel's `subtype` {value} must be lowercase.")
         if " " in cleaned_value:
-            raise ValueError("ConnectorModel's `subtype` must not contain any spaces.")
+            raise ValueError(
+                f"ConnectorModel's `subtype` {value} must not contain any spaces."
+            )
         return cleaned_value
 
     def logo(self, connectors_directory: Path) -> str:

tests/core/test_connector.py

@@ -1688,3 +1688,41 @@ def new_format(*args, **kwargs):
     assert str(excinfo.value) == (
         "Duplicate action name {} in `with_parameters_override` and `with_actions`"
     ).format(parameters_action_name.name)
+
+
+def test_connector_lowercase_subtype_constraint():
+    subtype = "SmartLeads"
+    with pytest.raises(ValidationError) as excinfo:
+        Connector(
+            name="SmartLeads",
+            type=ConnectorType.Other,
+            subtype=subtype,
+            description=DESCRIPTION,
+            url="https://www.smartleads.test/",
+            actions=[],
+        )
+    expected_error = (
+        "1 validation error for ConnectorModel"
+        "\nsubtype"
+        "\n  ConnectorModel's `subtype` {} must be lowercase. (type=value_error)"
+        .format(subtype)
+    )
+    assert str(excinfo.value) == expected_error
+
+
+def test_connector_space_subtype_constraint():
+    subtype = "smart leads"
+    with pytest.raises(ValidationError) as excinfo:
+        Connector(
+            name="SmartLeads",
+            type=ConnectorType.Other,
+            subtype=subtype,
+            description=DESCRIPTION,
+            url="https://www.smartleads.test/",
+            actions=[],
+        )
+    expected_error = (
+        "1 validation error for ConnectorModel\nsubtype\n  ConnectorModel's `subtype`"
+        " {} must not contain any spaces. (type=value_error)".format(subtype)
+    )
+    assert str(excinfo.value) == expected_error