Changelog for 3.x #127
Merged
Changelog for 3.x #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobThree
approved these changes
Apr 27, 2024
willpower232
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Some suggestions but seems fine to me.
@NicolasCARPi FYI I presume that the assignee should remain as yourself since the individual responsible for the work?
propose the use of named arguments Co-authored-by: Will Power <1619102+willpower232@users.noreply.github.com>
Co-authored-by: Will Power <1619102+willpower232@users.noreply.github.com>
You'r talking about this?
I'm not sure what is the difference between Assignees and Reviewers here... Maybe if one wants to separate the reviewing part from the merging part... |
|
Yeah, you can request reviews to get people on the reviewers list and then assign yourself as the assignee being the person responsible for working on the PR. There doesn't seem to be any hard and fast rules about it so mostly I see it getting ignored 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be the last PR before tagging 3.0.0!