Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ref: Drop Endpoint::_setSiblingMethods() #1539

Merged
merged 8 commits into from
Feb 3, 2024
Merged

Ref: Drop Endpoint::_setSiblingMethods() #1539

merged 8 commits into from
Feb 3, 2024

Conversation

RobinTail
Copy link
Owner

Getting rid of some ugliness.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Feb 2, 2024
@coveralls
Copy link

coveralls commented Feb 2, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 9c3b234 on ref-sibling-methods
into fd979f0 on master.

@RobinTail RobinTail marked this pull request as ready for review February 3, 2024 12:11
RobinTail
RobinTail commented Feb 3, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@RobinTail RobinTail merged commit 5e3e521 into master Feb 3, 2024
11 checks passed
@RobinTail RobinTail deleted the ref-sibling-methods branch February 3, 2024 12:27
@RobinTail RobinTail mentioned this pull request Feb 3, 2024
Merged
RobinTail added a commit that referenced this pull request Feb 3, 2024
@RobinTail
Drop public prop DependsOnMethod::endpoints (#1540)
f00634a 
Due to #1539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @coveralls