Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using generator in givePort() #2040

Merged
merged 10 commits into from
Sep 13, 2024
Merged

Using generator in givePort() #2040

merged 10 commits into from
Sep 13, 2024

Conversation

RobinTail
Copy link
Owner

No description provided.

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Sep 13, 2024
@RobinTail RobinTail marked this pull request as ready for review September 13, 2024 08:11
@RobinTail RobinTail changed the title Using generator fn for givePort() Using generator for givePort() Sep 13, 2024
@RobinTail RobinTail changed the title Using generator for givePort() Using generator in givePort() Sep 13, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 13, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 9199acd on simpler-give-port
into 218fc73 on master.

RobinTail
RobinTail commented Sep 13, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I'm glad

@RobinTail RobinTail merged commit b05b590 into master Sep 13, 2024
11 checks passed
@RobinTail RobinTail deleted the simpler-give-port branch September 13, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail