Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for missing install #51

Merged
merged 4 commits into from
May 13, 2022

Conversation

ZoteTheMighty
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty commented May 13, 2022

Better elaboration for a common error where a foreman-managed tool is being used outside of a scope in which it's been defined as a tool dependency.

Old error looked like this:

pdoyle:~/dev/projects/foreman (better-error-for-missing-install)
$ selene
'selene' is not a known Foreman tool, but Foreman was invoked with its name.
You may not have this tool installed here, or your install may be broken.

New error looks like this:

pdoyle:~/dev/projects/foreman (better-error-for-missing-install)
$ selene
'selene' is not a known Foreman tool, but Foreman was invoked with its name.

To use this tool from C:\Users\pdoyle\dev\projects\foreman, declare it in a 'foreman.toml' file in the current directory or a parent directory.

Available Tools:
         rojo => github.com/rojo-rbx/rojo@^6.0
         stylua => github.com/johnnymorganz/stylua@^0.13.0
         darklua => gitlab.com/seaofvoices/darklua@^0.7.0

Additionally, this tees up a 1.0.4 release.

Copy link
Contributor

@amatosov-rbx amatosov-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZoteTheMighty ZoteTheMighty merged commit af0b1e5 into master May 13, 2022
@ZoteTheMighty ZoteTheMighty deleted the better-error-for-missing-install branch May 13, 2022 21:48
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants