Take into account architecture when selecting linux artifact #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oltrep
reviewed
Sep 27, 2022
Comment on lines
+17
to
+21
| #[cfg(all(target_os = "linux", target_arch = "x86_64"))] | ||
| static PLATFORM_KEYWORDS: &[&str] = &["linux-x86_64", "linux"]; | ||
|
|
||
| #[cfg(all(target_os = "linux", target_arch = "aarch64"))] | ||
| static PLATFORM_KEYWORDS: &[&str] = &["linux-arm64", "linux-aarch64", "linux"]; |
There was a problem hiding this comment.
This will drop support for 32bit arch on linux, maybe it's preferable to add a gated declaration for those?
|
I have read the CLA Document and I hereby sign the CLA |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StyLua recently started producing
linux-aarch64builds. Foreman does not correctly take into account the architecture on linux, and selects thelinux-aarch64build whenlinux-x86_64should be used. This causes GitHub Actions CI to fail.We fix this by preferring a more explicit name in platform keywords for linux (depending on arch), and falling back to the generic one if nothing is found