Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some brittle snapshots based on github api responses #74

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Fix some brittle snapshots based on github api responses #74

merged 1 commit into from
Jul 18, 2023

Conversation

ZoteTheMighty
Copy link
Contributor

Updates snapshot tests, should unblock #71

@ZoteTheMighty
Copy link
Contributor Author

@matthargett I can't formally request you as a reviewer, but merging this and updating #71 should unblock its CI so we can get it in.

@matthargett
Copy link
Contributor

@matthargett I can't formally request you as a reviewer, but merging this and updating #71 should unblock its CI so we can get it in.

I approved, but it looks like is still needs another review somehow?

matthargett
matthargett approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@matthargett matthargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ZoteTheMighty ZoteTheMighty merged commit 55e2fba into main Jul 18, 2023
5 checks passed
@ZoteTheMighty ZoteTheMighty deleted the nojira-fix-snapshots branch July 18, 2023 16:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthargett matthargett matthargett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZoteTheMighty @matthargett