Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry backend and new command line options #45

Merged
merged 7 commits into from
Jul 23, 2020

Conversation

oltrep
Copy link
Contributor

@oltrep oltrep commented Jul 20, 2020

Closes #43

This PR adds a new backend that wraps another one and performs the retry logic when getting rate limited errors.

I've opened this as a draft PR because I have not tested it yet with real image uploads.

@oltrep
Copy link
Contributor Author

oltrep commented Jul 20, 2020

I have read the CLA Document and I hereby sign the CLA

@github-actions
Copy link

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise the structure of this looks solid!

src/sync_backend.rs Outdated Show resolved Hide resolved
@oltrep oltrep marked this pull request as ready for review July 23, 2020 13:14
Copy link
Contributor

@ZoteTheMighty ZoteTheMighty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZoteTheMighty ZoteTheMighty merged commit 858ba46 into Roblox:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add retry behavior to work around rate limiting
2 participants