Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of PackageMap and an ament resource #269

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Mar 30, 2023

Condensed, but less functional, version of #1

FYI @adeeb10abbas @jwnimmer-tri This example won't pass on CI or w/ Bazel archive, but should work if you use a package resource that actually exists.
In my case, I dumpster dove to find the test URDF. Better solution is to vendor our own.

Relates ament changes in #133


This change is Reviewable

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)


drake_ros_examples/test/parse_ros_model_test.py line 24 at r1 (raw file):

    # TODO(eric.cousineau): Use a non-test resource.
    parser.AddModelsFromUrl(
        "package://rviz_default_plugins/test_meshes/test.urdf"

Working: This needs a real package. Ideally, I pull in drake_example_pendulum from Addisu's example.

Copy link
Collaborator Author

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions

a discussion (no related file):
Working: Should wait until #133 lands.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant