Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to create Favicon.ico #1888

Closed
tuudik opened this issue Jan 13, 2016 · 34 comments
Closed

How to create Favicon.ico #1888

tuudik opened this issue Jan 13, 2016 · 34 comments

Comments

@tuudik
Copy link

tuudik commented Jan 13, 2016

Hi,

I have tried creating favicon with GIMP.
I have three different layers with icon sizes: 16, 32, 48.

Everytime I try to upload, error message Invalig File Type appears. Nothing in Debug log.

Help pls:)

@marceloschmidt
Copy link
Member

Hey @tuudik we have identified what we think is a problem on our File Upload. Would you mind sending us the file you are creating to support@rocket.chat, so we can improve and fix this for everyone else? Thanks!

@tuudik
Copy link
Author

tuudik commented Jan 13, 2016

Favicon sent:) One question more, when in iOS safari, sending shortcut to homescreen, it will use Rocket.Chat icon, is it expected behaviour?

@rodrigok
Copy link
Member

@tuudik there is a difference between browsers to detect the file mime type, if you try to upload your icon using chrome will work.

I fixed this problem, watch this PR #1893

@tuudik
Copy link
Author

tuudik commented Jan 13, 2016

Hmm but I used chrome:(

@rodrigok
Copy link
Member

@tuudik OS X, Windows or Linux?

@haceru
Copy link

haceru commented Jan 13, 2016

Hello, I had the same problem yesterday using Opera (Chrome based engine) and Windows 7 pro. The browser identified correctly the file as a .ico type, but the chat instance would not accept it due to "Invalid file type"

@tuudik
Copy link
Author

tuudik commented Jan 13, 2016

Windows 8.1 Pro

@LeCoupa
Copy link

LeCoupa commented Jan 27, 2016

I have the same problem with .ico extension. It says : Invalid file type : image/vnd.microsoft.icon

@rodrigok
Copy link
Member

@LeCoupa Which Rocket.Chat version are you using?

@LeCoupa
Copy link

LeCoupa commented Jan 27, 2016

I just used one week ago.

curl -L https://rocket.chat/releases/latest/download -o rocket.chat.tgz

@rodrigok
Copy link
Member

@LeCoupa can you go to /api/info to get the exact version you are using?

@LeCoupa
Copy link

LeCoupa commented Jan 27, 2016

@rodrigogs : "version": "0.15.0"

@rodrigok
Copy link
Member

@LeCoupa which browser and OS are you using? I can't reproduce your problem

@rodrigok
Copy link
Member

@LeCoupa Ok, the problem is that this mime type doesn't have extension in the library that we are using https://github.com/jshttp/mime-db/blob/master/db.json?ts=2#L5522-L5525

I will try to solve that

@rodrigok
Copy link
Member

@LeCoupa My latest commit solve your problem d790090?ts=2

@alvarow
Copy link

alvarow commented Jan 27, 2016

Can we add mime types for Apple Keynote, Pages and Numbers? I am unable to upload those.

@rodrigok
Copy link
Member

@alvarow for favicon? 😸

This verification is only for assets like favicon, logo, etc.

For normal uploads you can change the list of acceptable file types for upload in admin area under "File Uploads" section.

@alvarow
Copy link

alvarow commented Jan 27, 2016

Well. on File uploads... there's a white list of mime types too ... I added those, yet I still can't upload

@rodrigok
Copy link
Member

@alvarow can you create a new issue with more details about your problem?

@alvarow
Copy link

alvarow commented Jan 28, 2016

sure can.

@LeCoupa
Copy link

LeCoupa commented Jan 28, 2016

@rodrigok I reinstalled Rocket with curl -L https://rocket.chat/releases/latest/download -o rocket.chat.tgz

But it seems that I still get this error:
screen shot 2016-01-28 at 7 02 02 pm

Here is the favicon if you want to try: http://d1ujqdpfgkvqfi.cloudfront.net/favicon-generator/htdocs/favicons/2014-04-28/057994f5fa4400c347d690c07212b0e2.ico

@rodrigok
Copy link
Member

@LeCoupa you are downloading the latest release that is from our master, we do a new release every monday.

To get the fix you need to download our development version https://github.com/RocketChat/Rocket.Chat/archive/develop.zip

@LeCoupa
Copy link

LeCoupa commented Feb 6, 2016

It is working on my side! Thank you @rodrigok :-)

@rodrigok
Copy link
Member

rodrigok commented Feb 7, 2016

@LeCoupa ur welcome 😄

@ralphreijs
Copy link

ralphreijs commented Jul 24, 2017

Hi, I am still having this issue with 0.57.2.
Whatever type of .ico file I upload (tried a Mac tool for Icons, online PNG to ICO converters, etc), I get the same error about "Invalid file type : image/vnd.microsoft.icon".

screen shot 2017-07-24 at 21 22 33

What am I doing wrong? Any idea @rodrigok ?
Thanks,

Ralph

@Zaraka
Copy link

Zaraka commented Aug 8, 2017

0.57.2 linux chrome, firefox, desktop client with same result
invalid file type

@dancorrigan1
Copy link

Even trying to re-upload the default favicon.ico that comes with Rocketchat fails with the same error.

@2E0PGS
Copy link

2E0PGS commented Nov 19, 2017

indeed same issue here still persistent for over a year

@Supermathie
Copy link

Indeed, us as well on commit 65e06c2. Here's a file I'm having trouble with: rocket-chat-discourse.ico.gz

Created using:

convert rocket-chat-discourse.png -define icon:auto-resize=128,64,48,32,16 rocket-chat-discourse.ico

@Baa14453
Copy link

Any tips on creating a file that does work?

@Supermathie
Copy link

Supermathie commented Feb 24, 2018 via email

@Antairez
Copy link

Antairez commented Jun 2, 2018

Can we reopen this issue as many people still have issues with it?

@navigosgroupjsc
Copy link

I'm having the same issue, any solution?

@ooguz
Copy link

ooguz commented Feb 28, 2019

Hello everyone,

I was getting this error and there is no real solution on the web.

The solution is:

  • Go to "Administration"
  • Enter "File Upload" section
  • Append the file type which you get error at the end of "Accepted Media Types" field

Screenshot is on the link:

https://hackerspace.ist/ico_problem_solution.png

Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests