Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double negative in Sound Preferences #2385

Closed
pcarn opened this issue Feb 29, 2016 · 0 comments · Fixed by #2937
Closed

Double negative in Sound Preferences #2385

pcarn opened this issue Feb 29, 2016 · 0 comments · Fixed by #2937
Assignees
@sampaiodiego
Labels
type: improvement

Comments

@pcarn
Copy link

pcarn commented Feb 29, 2016

Your Rocket.Chat version: 0.19.0

Right now, in Preferences->Sound, there is a double negative in the options.

Disable New Room Notification (True, False)
Disable New Message Notification (True, False)

If set to false, this is a double negative, and is confusing either way.
I would change to:
New Room Notification (On, Off)
New Message Notification (On, Off)
@engelgabriel engelgabriel added this to the 0.23.0 milestone Mar 10, 2016
@engelgabriel engelgabriel modified the milestones: 0.24.0, 0.23.0 Mar 22, 2016
@engelgabriel engelgabriel modified the milestones: 0.24.0, 0.25.0, 0.26.0 Mar 29, 2016
@engelgabriel engelgabriel modified the milestones: 0.26.0, 0.27.0 Apr 11, 2016
@marceloschmidt marceloschmidt mentioned this issue Apr 18, 2016
Merged
@marceloschmidt marceloschmidt modified the milestone: 0.27.0 Apr 18, 2016
engelgabriel pushed a commit that referenced this issue Apr 19, 2016
@marceloschmidt @engelgabriel
Closes #2726 #2385 Remove double negatives (#2937)
d315b7b 
* Change naming for opt-out statistics

* Opt out description

* Remove double negatives:

New room notification;
New message notification;
Statistics opt out

* Statistics reporting

* Remove double negative on Disable Favorite Rooms

* Change logic for checking if message and room notifications are enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sampaiodiego sampaiodiego

Labels
type: improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove double negatives RocketChat/Rocket.Chat
4 participants
@engelgabriel @marceloschmidt @pcarn @sampaiodiego