Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Button on user info contextual bar scrolling with the content #10358

Merged
merged 6 commits into from
Apr 18, 2018

Conversation

okaybroda
Copy link
Contributor

@RocketChat/core

The latest release 0.63 made a change that made all contextual bars to be scrolling with the button instead of the button being a sticky. This was suppose to be a fix to user info tab.

Reverted the style changes in contextual-bar.css file and fixed user info tab with a wrapper.

image

@CLAassistant
Copy link

CLAassistant commented Apr 6, 2018

CLA assistant check
All committers have signed the CLA.

@okaybroda
Copy link
Contributor Author

This PR addresses this bug #10353

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10358 April 10, 2018 22:55 Inactive
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10358 April 10, 2018 23:55 Inactive
@ggazzo ggazzo self-requested a review April 10, 2018 23:56
@ggazzo ggazzo temporarily deployed to rocket-chat-pr-10358 April 11, 2018 17:55 Inactive
@karlprieb karlprieb added this to the 0.64.0 milestone Apr 12, 2018
karlprieb
karlprieb previously approved these changes Apr 12, 2018
@graywolf336 graywolf336 changed the title [FIX] user info content scrolling with button [FIX] Button on user info contextual bar scrolling with the content Apr 18, 2018
@engelgabriel engelgabriel requested a deployment to rocket-chat-pr-10358 April 18, 2018 03:20 Abandoned
@graywolf336 graywolf336 merged commit adb3f97 into RocketChat:develop Apr 18, 2018
MarcosSpessatto added a commit that referenced this pull request Apr 19, 2018
…-api-chat-postmessage-validations

* commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits)
  Remove "secret" from REST endpoint /settings.oauth response
  [FIX] Directory sort and column sizes were wrong (#10403)
  [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299)
  Show error message when email verification fails (#10446)
  Correct the column positions in the directory search for users (#10454)
  Fixed custom fields misalignment in registration form (#10463)
  [FIX] Unique identifier file not really being unique (#10341)
  [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335)
  [FIX] Empty panel after changing a user's username (#10404)
  [FIX] Russian translation of "False" (#10418)
  [FIX] Links being embedded inside of blockquotes (#10496)
  [FIX] The 'channel.messages' REST API Endpoint error (#10485)
  [OTHER] Develop sync (#10487)
  [FIX] Button on user info contextual bar scrolling with the content (#10358)
  [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824)
  [NEW] Body of the payload on an incoming webhook is included on the request object (#10259)
  [FIX] Missing i18n translation key for "Unread" (#10387)
  [FIX] Owner unable to delete channel or group from APIs (#9729)
  [NEW] REST endpoint to recover forgotten password (#10371)
  Add REST endpoint chat.reportMessage, to report a message (#10354)
  ...
@rodrigok rodrigok mentioned this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants